On Sun, Mar 30, 2014 at 12:56 PM, Dirk Hohndel dirk@hohndel.org wrote:
Should libdivecomputer ignore the error when on a PTY?
Yeah, I don't see any better approach.
In fact, I'd suggest that libdivecomputer get rid of all those checks entirely, and get rid of the whole "ENABLE_PTY" thing. Maybe the errors can be logged to the log-file, but they should be considered at most warnings, not errors.
Some settings just don't make sense for all serial lines. Maybe they are pty's. Maybe there is some glibc idiocy. Maybe they are some emulated other thing that doesn't do a complete job, but works well enough otherwise. Who cares? Making the errors fatal just make things *worse*.
And hiding them under ENABLE_PTY doesn't really help anything, just adds configuration complexity and makes the code uglier.
Linus