Re: [PATCH] Add wrappers to read and write Vyper settings

On 2014-10-10 07:45, Anton Lundin wrote:

This adds symbols that is exported from libdivecomputer for programs who would like to read and write settings.

[...]

+dc_status_t +suunto_vyper_device_config_read(dc_device_t *abstract, unsigned int config, unsigned char data[], unsigned int size) +{

• return suunto_vyper_device_read(abstract, config, data, size);

+}

+dc_status_t +suunto_vyper_device_config_write(dc_device_t *abstract, unsigned int config, const unsigned char data[], unsigned int size) +{

• return suunto_vyper_device_write(abstract, config, data, size);

+}

These two functions are already exported as dc_device_read and dc_device_write. And they are available for all backends (unless the protocol doesn't support reading/writing), so I don't really see the point of your patch.

Jef