On 21 December, 2014 - Jef Driesen wrote:
On 20-12-14 12:13, Anton Lundin wrote:
On 20 December, 2014 - Anton Lundin wrote:
I still like my way of parsing the firmware files better than yours, but if you want it that way, fine.
It's a bit less efficient then your version (e.g. a few more fread calls), but I prefer to use the same pattern throughout the entire codebase. We already had this code for the ostc, so it doesn't make much sense to introduce another variant for the ostc3.
I did do a round of cleanup, and to test how things looked with the hw_ostc3_device_init-code and they are all how cleaned and fixed on github.
If you would like to see them, i can send them out, or you can look at: https://github.com/glance-/libdivecomputer/tree/ostc3_fw
I did a few minor style cleanups here and there, and pushed everything to master.
Thanks for your work!
Thank you for doing a proper review and keeping my code honest.
//Anton