January 2018 - devel - libdivecomputer.org

libdivecomputer server migration
by Jef Driesen 20 Jan '18

20 Jan '18

Hi, The libdivecomputer infrastructure is being migrated to another server. This will affect the following services: * Website and mailinglist These services have already been migrated. This is supposed to be fully transparent, although you might experience a little downtime today. * Git The git repository on github will become the primary repository. Sourceforge will remain as a mirror, but the libdivecomputer git server will be shut down at the end of the month. You can easily change the repository url with: git remote set-url origin https://github.com/libdivecomputer/libdivecomputer.git * Trac tickets and wiki The trac bug tracker and wiki pages will also be replaced with github. The existing tickets will NOT be migrated. There are only a few tickets in the system, so it's not really worth the effort. The wiki pages will be imported into github (once I have figured out how to do that). The trac server will also be shutdown at the end of the month. Jef

2 4

Permanent mirror of repository on GitHub?
by Henrik B A 05 Jan '18

05 Jan '18

Hi Jef. Would you consider creating a permanent & updated mirror of libdevcomputer on GitHub? I like browsing the source code in a browser, and GitHub is such a good tool for doing that. The web interface at http://git.libdivecomputer.org/?p=libdivecomputer.git;a=summary is slow, times out a lot, and is really not very usable. Cheers, Henrik

4 7

V3: Coverity / static analysis based cleanups
by Dirk Hohndel 04 Jan '18

04 Jan '18

Third version of this series. I addressed Jef's comments and dropped both patches that dealt with the dc_buffer code as they did more damage than good. Maybe I'll do a new set of patches just for the buffer code if I feel bored later. /D [PATCH 01/12] Cleanup: correctly handle upper bound of array [PATCH 02/12] Cleanup: avoid memory leaks [PATCH 03/12] Cleanup: avoid memory leak [PATCH 04/12] Cleanup: avoid memory leak [PATCH 05/12] Cleanup: avoid memory leak [PATCH 06/12] Cleanup: ensure string is 0 terminated [PATCH 07/12] Cleanup: avoid undefined shift operation [PATCH 08/12] Cleanup: remove dead code and return the correct return [PATCH 09/12] Cleanup: check return value of ioctl() [PATCH 10/12] Cleanup: consistently check return value of iostream [PATCH 11/12] Cleanup: bail on error [PATCH 12/12] Cleanup: remove confusing NULL check

2 14

V2: Coverity / static analysis based cleanups
by Dirk Hohndel 04 Jan '18

04 Jan '18

This is the second version of a series of 14 patches against the current tip of the Subsurface-branch of libdivecomputer. I believe that all of them should apply to upstream master (but haven't verified that). I have incorporated Jef's feedback on the first version. One change compared to my email responses to that feedback is that I ended up not modifying patch 12/14 (consistently check return value of iostream) as it made the code really ugly and as Jef said, not resetting the timeout doesn't really matter. Linus, based on your feedback and Jef's comment I rewrote 7/14; can you please double check that I didn't mess this up by combining it all in one operation? Happy to get more feedback / comments. Thanks /D [PATCH 01/14] Cleanup: correctly handle upper bound of array [PATCH 02/14] Cleanup: avoid memory leaks [PATCH 03/14] Cleanup: avoid memory leak [PATCH 04/14] Cleanup: avoid memory leak [PATCH 05/14] Cleanup: avoid memory leak [PATCH 06/14] Cleanup: ensure string is 0 terminated [PATCH 07/14] Cleanup: avoid undefined shift operation [PATCH 08/14] Cleanup: remove dead code and return the correct return [PATCH 09/14] Cleanup: dc_buffer_clear() should be a void function [PATCH 10/14] Cleanup: check return value of ioctl() [PATCH 11/14] Cleanup: check error return values of buffer handling [PATCH 12/14] Cleanup: consistently check return value of iostream [PATCH 13/14] Cleanup: bail on error [PATCH 14/14] Cleanup: remove confusing NULL check

3 22

Any interest in a VR3 integration?
by Dirk Niggemann 04 Jan '18

04 Jan '18

I realize that Delta P has been out of business for many years and the vr3 is now positively antique and but was wondering if anybody was still interested in supporting the interface. I was going to have a go at it given that i have all the avialble download software, but was wondering whether there was any intereset anymore. Regards, Dirk Niggemann

2 1

Coverity / static analysis based cleanups
by Dirk Hohndel 03 Jan '18

03 Jan '18

This is a series of 14 patches against the current tip of the Subsurface-branch of libdivecomputer. I believe that all of them should apply to upstream master (but haven't verified that). Some of them are clear bug fixes, some of them are equally clear fixes to avoid memory leaks. A few deal with cases where the current code ignores the return values of functions - that last type I am not always 100% sure about my resolution... All of them were generated based on a Coverity scan of Subsurface, built on Linux. This series should address all of the currently open Coverity issues that aren't rather obvious false positives. As usual, one can argue whether all of these issues are indeed bugs and how they should be fixed (e.g., should we check return values and return errors to our callers, or is it safe to ignore certain errors (in which case that should be done explicitly for consistency)). Happy to get feedback / comments. Thanks /D [PATCH 01/14] Cleanup: correctly handle upper bound of array [PATCH 02/14] Cleanup: avoid memory leaks [PATCH 03/14] Cleanup: avoid memory leak [PATCH 04/14] Cleanup: avoid memory leak [PATCH 05/14] Cleanup: avoid memory leak [PATCH 06/14] Cleanup: ensure string is 0 terminated [PATCH 07/14] Cleanup: avoid undefined shift operation [PATCH 08/14] Cleanup: remove dead code and return the correct return [PATCH 09/14] Cleanup: be explicit about ignoring the return value of [PATCH 10/14] Cleanup: check return value of ioctl() [PATCH 11/14] Cleanup: check error return values of buffer handling [PATCH 12/14] Cleanup: consistenty check return value of iostream [PATCH 13/14] Cleanup: bail on error [PATCH 14/14] Cleanup: remove confusing NULL check

3 28