devel August 2016

devel@libdivecomputer.org

4 participants
6 discussions

More Uwatec Aladin TEC2G Log Data
by Thomas Gschwind 02 Jun '17

02 Jun '17

Hi there, I am using Subsurface and it reports all my salt water dives deeper than they really are. So I downloaded the latest libdivecomputer sources and looked at the code. The tec2g_header claims that the salinity setting of this dive computer is not supported. After looking at the dumps included in my SmartTRAK log where the dives are correctly reported (SmartTRAK is nice enough to store the original dc data), I am most certain to have located the salinity field in byte 62 of the header. Another indication is that it is also bit 0x10 as it is for the others (see get water in uwatec_smart_parser_cache). Just tried out setting the salinity field to 62 and works perfectly fine for me. Similarly, the timezone field most likely is 16. However, that one I cannot test so well because the immersion time seems to be relative to the dive computers system time which seems to be missing in the SmartTRAK logs. But manually looking at the time zones, it matched for the first 50+ of my dives. I also figured out the max ppo2 configuration and partially the tissue saturation before the dive --- if anybody is interested that data as well. See http://tomsblog.gschwinds.net/2016/08/uwatec-smarttrak-and-aladin-tec2g/ for details. Best, Thomas

3 6

[PATCH 3/3] Suunto EON Steel: extend our string space
by Linus Torvalds 29 Aug '16

29 Aug '16

From: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Mon, 29 Aug 2016 15:03:02 -0700 Subject: [PATCH 3/3] Suunto EON Steel: extend our string space We only used to save 16 extended strings per dive from the EON Steel download, which is _plenty_: it's not like we actually generate that many strings. Firmware version, battery status, transmitter info - there's just not that many strings. Oops. Except if you have lots of transmitters. Then each wireless transmitter will have three strings each, for transmitter ID and beginning/ending battery status. I only have one, but Andreas Klein has four. And it took me embarrassingly long to realize that he really did have them on the dives, because after the first two transmitter IDs got recorded, the string space filled up and we silently dropped the rest. But I have learnt my lesson. Future generations will talk about how I said "32 strings will be enough for anybody". But at least it should be enough for a few more transmitters. Somebody should extend this some better way, but I'm still chasing other issues. Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> --- src/suunto_eonsteel_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/suunto_eonsteel_parser.c b/src/suunto_eonsteel_parser.c index 8a7d3d15cbc8..fc1301d94139 100644 --- a/src/suunto_eonsteel_parser.c +++ b/src/suunto_eonsteel_parser.c @@ -80,7 +80,7 @@ struct type_desc { #define MAXTYPE 512 #define MAXGASES 16 -#define MAXSTRINGS 16 +#define MAXSTRINGS 32 typedef struct suunto_eonsteel_parser_t { dc_parser_t base; -- 2.10.0.rc0.2.g0a9fa47

1 0

[PATCH 2/3] Suunto EON Steel: initialize the tank 'gasmix' index
by Linus Torvalds 29 Aug '16

29 Aug '16

From: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Mon, 29 Aug 2016 15:03:02 -0700 Subject: [PATCH 2/3] Suunto EON Steel: initialize the tank 'gasmix' index The gasmix query interface considers cylinders and gas mixes independent things, so the tank data structure has a pointer to the gasmix index. But the EON Steel treats cylinders as just having a gasmix (and so does subsurface, for that matter), so the gasmix index for the tank is just the same as the tank index. But we never filled it in, so you'd always see a "gas index" of zero, and subsurface would end up warning each time about how the gasmix index doesn't match the cylinder index (but because subsurface actually agreed with EON Steel, it worked despite the warning). Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> --- src/suunto_eonsteel_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/suunto_eonsteel_parser.c b/src/suunto_eonsteel_parser.c index bba26ef71fda..8a7d3d15cbc8 100644 --- a/src/suunto_eonsteel_parser.c +++ b/src/suunto_eonsteel_parser.c @@ -1034,6 +1034,7 @@ suunto_eonsteel_parser_get_field(dc_parser_t *parser, dc_field_type_t type, unsi * that metric is (at least so far) always whole liters */ tank->volume = eon->cache.tanksize[flags]; + tank->gasmix = flags; /* * The pressure reported is NOT the pressure the user enters. -- 2.10.0.rc0.2.g0a9fa47

1 0

[PATCH 1/3] Suunto EON Steel: do the proper enum lookup for a few more cases
by Linus Torvalds 29 Aug '16

29 Aug '16

From: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Sun, 28 Aug 2016 12:56:09 -0700 Subject: [PATCH 1/3] Suunto EON Steel: do the proper enum lookup for a few more cases Instead of hardcoding the enum values for setpoint type and gas type, use "lookup_enum()" to actually parse the enum data and use that. I don't think this matters right now, since the numeric translations haven't changed, but it is the RigthThing(tm) to do. Signed-off-by: Linus Torvalds <torvalds(a)linux-foundation.org> --- src/suunto_eonsteel_parser.c | 43 +++++++++++++++++++++++-------------------- 1 file changed, 23 insertions(+), 20 deletions(-) diff --git a/src/suunto_eonsteel_parser.c b/src/suunto_eonsteel_parser.c index 2be21cf0483a..bba26ef71fda 100644 --- a/src/suunto_eonsteel_parser.c +++ b/src/suunto_eonsteel_parser.c @@ -776,21 +776,24 @@ static void sample_event_alarm_value(const struct type_desc *desc, struct sample static void sample_setpoint_type(const struct type_desc *desc, struct sample_data *info, unsigned char value) { dc_sample_value_t sample = {0}; + const char *type = lookup_enum(desc, value); - switch (value) { - case 0: + if (!type) { + DEBUG(info->eon->base.context, "sample_setpoint_type(%u) did not match anything in %s", value, desc->format); + return; + } + + if (!strcasecmp(type, "Low")) sample.ppo2 = info->eon->cache.lowsetpoint; - break; - case 1: + else if (!strcasecmp(type, "High")) sample.ppo2 = info->eon->cache.highsetpoint; - break; - case 2: + else if (!strcasecmp(type, "Custom")) sample.ppo2 = info->eon->cache.customsetpoint; - break; - default: - DEBUG(info->eon->base.context, "sample_setpoint_type(%u)", value); + else { + DEBUG(info->eon->base.context, "sample_setpoint_type(%u) unknown type '%s'", value, type); return; } + if (info->callback) info->callback(DC_SAMPLE_SETPOINT, sample, info->userdata); } @@ -1110,24 +1113,24 @@ static int add_gas_type(suunto_eonsteel_parser_t *eon, const struct type_desc *d { int idx = eon->cache.ngases; dc_tankinfo_t tankinfo = DC_TANKINFO_METRIC; + const char *name; if (idx >= MAXGASES) return 0; eon->cache.ngases = idx+1; - switch (type) { - case 0: - tankinfo = 0; - break; - case 3: + name = lookup_enum(desc, type); + if (!name) + DEBUG(eon->base.context, "Unable to look up gas type %u in %s", type, desc->format); + else if (!strcasecmp(name, "Diluent")) tankinfo |= DC_TANKINFO_CC_DILUENT; - break; - case 4: + else if (!strcasecmp(name, "Oxygen")) tankinfo |= DC_TANKINFO_CC_O2; - break; - default: - break; - } + else if (!strcasecmp(name, "None")) + tankinfo = 0; + else if (strcasecmp(name, "Primary")) + DEBUG(eon->base.context, "Unknown gas type %u (%s)", type, name); + eon->cache.tankinfo[idx] = tankinfo; eon->cache.initialized |= 1 << DC_FIELD_GASMIX_COUNT; -- 2.10.0.rc0.2.g0a9fa47

1 0

[PATCH 0/3] Some EON Steel libdivecomputer fixups
by Linus Torvalds 29 Aug '16

29 Aug '16

So I've been looking at the EON Steel backend because Andreas Klein has a slightly more complex situation than the one I use, notably multiple wireless transmitters. That showed a few issues. The first patch actually predates all this work, and was just a cleanup from before. The two other patches are trivial fixes for trivial issues I've found so far. One causes an annoying and misleading warning in subsurface, and the other one results in the transmitter information not being saved if you have more than two wireless transmitters. The actual *big* problem is that subsurface itself doesn't handle the issue of multiple concurrent transmitters right. Most (all?) other dive computers just give the pressure for the currently selected cylinder, if they support multiple pressure sensors at all. But these are real cleanups/fixes regardless. Linus Torvalds (3): Suunto EON Steel: do the proper enum lookup for a few more cases Suunto EON Steel: initialize the tank 'gasmix' index Suunto EON Steel: extend our string space src/suunto_eonsteel_parser.c | 46 ++++++++++++++++++++++++-------------------- 1 file changed, 25 insertions(+), 21 deletions(-) -- 2.10.0.rc0.2.g0a9fa47

1 0

Re: new restaurant opening
by david.lerouesnier 12 Aug '16

12 Aug '16

Hi friend! I've heard about a new fish restaurant opening next saturday, are you planning to go there? Here is some info about that <http://ntywophyva.hairon5thavenue.com/lnczrj> Yours, david.lerouesnier

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

devel August 2016