devel July 2014

devel@libdivecomputer.org

6 participants
4 discussions

[PATCH] Unsigned int type can't be below zero
by Anton Lundin 05 Aug '14

05 Aug '14

This fixes a always false comparison that a unsigned int can never be below zero. This was found when compiling with clang. Signed-off-by: Anton Lundin <glance(a)acc.umu.se> --- src/ihex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ihex.c b/src/ihex.c index 69df787..46b4b81 100644 --- a/src/ihex.c +++ b/src/ihex.c @@ -142,7 +142,7 @@ dc_ihex_file_read (dc_ihex_file_t *file, dc_ihex_entry_t *entry) /* Get the record type. */ type = data[3]; - if (type < 0 || type > 5) { + if (type > 5) { ERROR (file->context, "Invalid record type (0x%02x).", type); return DC_STATUS_DATAFORMAT; } -- 1.9.1

3 2

Still having issues with a Pro Plus 2
by Philip Balister 10 Jul '14

10 Jul '14

I'm not sure this issue was ever fixed: http://libdivecomputer.org/pipermail/devel/2012-January/000039.html I managed to go diving again this past weekend :) I renamed the old subsurface.ml file and now see this error in the log: INFO: Write: size=6, data=3401A901AC00 INFO: Read: size=1, data=5A INFO: Read: size=68, data=B007FE0617001400288321483500001645005000099F004BC00040001186004BC0E5004000137E004CC0004010147B004CC0C80140001332004CA0014000132D004C90CF INFO: Write: size=6, data=3401A501A800 INFO: Read: size=1, data=5A INFO: Read: size=68, data=2770000E12004D302770100C15004D40892770400910004D3000000000000000006D5E50051E4D56F10BBADCFE002143658754251FDC219F1B1413840D6C0B040A5B089B ERROR: Unexpected number of samples with the same timestamp. [in oceanic_vtpro_parser.c:284 (oceanic_vtpro_parser_samples_foreach)] INFO: Write: size=4, data=6A05A500 INFO: Read: size=1, data=5A INFO: Read: size=1, data=51 libdc is installed from the Fedora 20 rpm. libdivecomputer-0.4.2-1.fc20.x86_64 libdivecomputer-devel-0.4.2-1.fc20.x86_64 I'm using subsurface master. Let me know if you need any other info. Thanks Philip

2 4

Programming questions
by John Van Ostrand 07 Jul '14

07 Jul '14

Hi, I've started writing libdivecomputer code for the Cochran and I have a few questions that I expect are easy answers. 1. I'm wondering how much I should read in the _init function. It seems I should read enough to verify I'm talking to the right device and get the serial number. Is that right? 2. There are other reads I can do that will get things like # of dives, gas mixtures, conservatism, etc. I need number of dives to read the log book. Should I do this in _read? And does it make sense to do this read before setting progress information? 3. I have extra information that I can offer the user, pre- and post-dive things like battery voltage, tissue load, time to fly, previous SIT, repetitive dive count and dive profiles samples like tissue load every 24 seconds, NDL remaining (I think), deco required (I think), ascent rate. I can also get post dive off-gassing tissue load and temperature samples. The DC continues to log samples until off-gassed I can't see any structure for all of this, or a way to carry around that kind of data. 4. The DC requires some prodding to accept commands, after being prompted it emits a byte every second. Initially it's a 0xAA but after reading dive samples it's a 0x00. The only way I've been able to prompt it is to send a byte to it. The vendor software doesn't do this. Could it be a USB signal of some sort. I see "Sync Reset Pipe and Clear Stall" in the USB capture and "Vendor Device" and "Control transfer". Any ideas on what I might try? -- John Van Ostrand At large on sabbatical

2 1

Help needed decoding data
by John Van Ostrand 03 Jul '14

03 Jul '14

Hi All, I've been staring at and playing with this data for a week now and I don't feel any closer to deciphering the dive profile sample data from my Cochran EMC-20H. Personally I love a challenge like this and I'm hoping some of you do as well because this one is tough. Instead of digging into a good book this weekend why not sit back with a laptop or tablet and this puzzle. You'll find everything you need at the link below. I've removed the mundanely easy work from this puzzle. Included are binary files, annotated hexdumps to illustrate the data and some programs to extract and display data (don't judge, these are quick and dirty programs.) Start with the README and you'll be into the fun part within minutes. https://drive.google.com/file/d/0B-VD5cn7zgGHN1pVRWpib2pJc0k/edit?usp=shari… -- John Van Ostrand At large on sabbatical

4 9

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

devel July 2014