first stab at Aeris A300CS support

[Jef Driesen]

In the oceanic_atom2_device_t struct.

On September 26, 2014 5:37:19 PM CEST, Dirk Hohndel <dirk at hohndel.org> wrote:
>On Fri, Sep 26, 2014 at 09:52:05AM +0200, Jef Driesen wrote:
>> 
>>  * You used global variables for the cache and its bitmap. That's
>simply not
>> acceptable. Please move this into the device handle. (I suggest you
>use the
>> name "bitmap" instead of "tracker". In the ostc backend we already
>used
>> "bitmap" for the exact same purpose.) And then you can pre-allocate
>> everything in the open function.
>> 
>>  * Remove the read_big_pages from the layout. The layout is intended
>for the
>> logic in the shared oceanic_common_device_xxx functions. But didn't
>change
>> anything there. You actually introduced a bug in the vtpro and veo250
>> backends, because their layouts were not updated with the new field.
>So
>> instead add some "bigpage" field directly to the device handle.
>
>Just to make sure I understand you correctly. You want me to add this
>to
>dc_device_t directly? That seems a fairly generic structure to me, I'm
>surprised you want such device specific data in there.
>
>Or is there some more libdivecomputer magic that I'm missing where you
>can
>add extra data to that? I just want to avoid more round trips with thow
>away code.
>
>/D
>_______________________________________________
>devel mailing list
>devel at libdivecomputer.org
>http://libdivecomputer.org/cgi-bin/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://libdivecomputer.org/pipermail/devel/attachments/20140926/1560c274/attachment.html>