<html><head></head><body>In the oceanic_atom2_device_t struct.<br><br><div class="gmail_quote">On September 26, 2014 5:37:19 PM CEST, Dirk Hohndel <dirk@hohndel.org> wrote:<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<pre class="k9mail">On Fri, Sep 26, 2014 at 09:52:05AM +0200, Jef Driesen wrote:<br /><blockquote class="gmail_quote" style="margin: 0pt 0pt 1ex 0.8ex; border-left: 1px solid #729fcf; padding-left: 1ex;"> <br /> * You used global variables for the cache and its bitmap. That's simply not<br /> acceptable. Please move this into the device handle. (I suggest you use the<br /> name "bitmap" instead of "tracker". In the ostc backend we already used<br /> "bitmap" for the exact same purpose.) And then you can pre-allocate<br /> everything in the open function.<br /> <br /> * Remove the read_big_pages from the layout. The layout is intended for the<br /> logic in the shared oceanic_common_device_xxx functions. But didn't change<br /> anything there. You actually introduced a bug in the vtpro and veo250<br /> backends, because their layouts were not updated with the new field. So<br /> instead add some "bigpage" field directly to the device handle.<br /></blockquote><br />Just to make
sure I understand you correctly. You want me to add this to<br />dc_device_t directly? That seems a fairly generic structure to me, I'm<br />surprised you want such device specific data in there.<br /><br />Or is there some more libdivecomputer magic that I'm missing where you can<br />add extra data to that? I just want to avoid more round trips with thow<br />away code.<br /><br />/D<br /><hr /><br />devel mailing list<br />devel@libdivecomputer.org<br /><a href="http://libdivecomputer.org/cgi-bin/mailman/listinfo/devel">http://libdivecomputer.org/cgi-bin/mailman/listinfo/devel</a><br /><br /></pre></blockquote></div></body></html>