Patches to add basic support for the Suunto EON Steel

Linus Torvalds torvalds at linux-foundation.org
Mon Nov 3 08:23:52 PST 2014


On Nov 3, 2014 8:12 AM, "Jef Driesen" <jef at libdivecomputer.org> wrote:
>
>
> I still prefer to have proper integration of the logging functions.
Calling ERROR from your report_error is an ugly hack that throws away
several of the nice features of the ERROR macro.

By it fixes one huge big mistake in that macro namely the broken return
value. Even if I could use the enums (which are not appropriate), the enum
you return is useless, since it's "success*.

But i can make my wrapper a macro, that _just_ fixes the return value. That
ok?

    Linus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://libdivecomputer.org/pipermail/devel/attachments/20141103/69339cc4/attachment.html>


More information about the devel mailing list