[PATCH 09/14] Cleanup: dc_buffer_clear() should be a void function

Dirk Hohndel dirk at hohndel.org
Thu Jan 4 08:46:12 PST 2018


On Thu, Jan 04, 2018 at 02:53:26PM +0100, Jef Driesen wrote:
> Another concern is that the dc_buffer_clear() function is part of the public
> api. So this change might break some applications. I don't mind doing this
> particular change, because it makes sense. But at the same time we also need
> to be careful that a simple fix to silence coverity doesn't turns into a
> problem for applications. (I don't think there are many applications using
> this function, but I don't know for sure.)

Then let's just skip that whole patch from this series and figure out what
you want to do regarding the API independent from this series. You are
correct, a Coverity warning is a silly reason for a change that might be a
lot more invasive in the end than initially considered.

/D


More information about the devel mailing list