[PATCH] Skip unconnected ppo2 sensors

Anton Lundin glance at acc.umu.se
Thu Sep 3 11:01:56 PDT 2015


On 03 September, 2015 - Jef Driesen wrote:

> On 2015-08-31 23:06, Anton Lundin wrote:
> >The HwOS devices logs ppo2 sensor values even in Auto / Fixed SP mode,
> >but they log them as reading zero, if there are no sensors there.
> 
> Am I right that in this particular case all three ppo2 values are
> zero (e.g. no sensors at all)? I remember seeing that in some of the
> original OSTC memory dumps. Then it makes indeed sense to omit the
> ppo2 values. But if there is one or more non-zero values, I don't
> think we should omit just the zero ones.
> 

In the Auto / Fixed SP mode all three values are zero, and stays zero
during the hole dive.

This fix isn't bug-free, eg if a sensor gets disconnected during a dive,
we should report zero for that, but it feels like the lesser evil than
the current code.


I dropped a mail to HW suggesting to just not log any sensors in Auto /
Fixed SP mode which would kinda make sense. Right now the HwOS based
devices logs ppo2 in all CCR modes.


//Anton


-- 
Anton Lundin	+46702-161604


More information about the devel mailing list