[PATCH] Added support for parsing temperature in the dive header

[Linus Torvalds]

On Sep 5, 2014 9:27 AM, "Jef Driesen" <jef at libdivecomputer.org> wrote:
>
> But what about header data, like begin/end pressure, temperature,
maxdepth, divetime, etc? There are several devices where such information
isn't available from the header, but where it's (indirectly) in the sample
data. In that case libdivecomputer can calculate the missing info from the
sample data. I already do that in a few places for divetime and maxdepth.

I can mind of see the point of doing max depth and time, just to always
have those fields in the header data for a dive.

But cylinder pressures etc? Bad idea. They aren't always there anyway,
claiming them just because you also have sample data is just wrong, stupid,
and print to error (ie the cylinder connected to the pressure sensor may
not be the first one, you don't know, stop guessing).

So don't add implied data. Even max depth and time is debatable (max time
based on samples should take surface time into account, do you? Probably
not), anything else is just really wrong.

If you can do it from sample data, then the real application that probably
can do better and more (like correlate "multiple* she computers etc). Your
calculated value at best might be just wrong, at worst they mess up a
better calculation.

Give what the dive computer gives. Nothing more. Nothing less.

     Linus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://libdivecomputer.org/pipermail/devel/attachments/20140905/aeff298e/attachment.html>