[PATCH] Add wrappers to read and write Vyper settings

Anton Lundin glance at acc.umu.se
Fri Oct 10 01:06:24 PDT 2014


On 10 October, 2014 - Jef Driesen wrote:

> On 2014-10-10 07:45, Anton Lundin wrote:
> >This adds symbols that is exported from libdivecomputer for programs who
> >would like to read and write settings.
> >
> >[...]
> >
> >+
> >+dc_status_t
> >+suunto_vyper_device_config_read(dc_device_t *abstract, unsigned int
> >config, unsigned char data[], unsigned int size)
> >+{
> >+	return suunto_vyper_device_read(abstract, config, data, size);
> >+}
> >+
> >+dc_status_t
> >+suunto_vyper_device_config_write(dc_device_t *abstract, unsigned int
> >config, const unsigned char data[], unsigned int size)
> >+{
> >+	return suunto_vyper_device_write(abstract, config, data, size);
> >+}
> 
> These two functions are already exported as dc_device_read and
> dc_device_write. And they are available for all backends (unless the
> protocol doesn't support reading/writing), so I don't really see the point
> of your patch.
> 

Ah, even better! =)

I must have missed that they are exported via the vtable, due to the
fact that those functions are static.

Thanks!


//Anton


-- 
Anton Lundin	+46702-161604


More information about the devel mailing list