Patches to add basic support for the Suunto EON Steel

Jef Driesen jef at libdivecomputer.org
Mon Nov 24 05:40:16 PST 2014


On 2014-11-21 20:51, Linus Torvalds wrote:
> On Fri, Nov 21, 2014 at 2:39 AM, Jef Driesen <jef at libdivecomputer.org> 
> wrote:
>> 
>> I have one specific question about the type_desc array. It seems it's 
>> only
>> populated, but never used for anything. Is this some leftover from 
>> earlier
>> prototyping, or is this something that should be kept?
> 
> It's used. See the whole entry traversal, traverse_dynamic_fields() in
> particular.
> 
> This is not prototyping code.
> 
> It isn't needed for the really basic sample data (which uses the types
> that always seem to be static), but all the events etc need it.
> 
> Maybe you're still working with just the basic model because you
> haven't done the DC_FIELD_STRING parts yet.

You're right, I'm only looking at the basic patch without the new string 
stuff. So I left the code, and just fixed the memory leak.

The eonsteel backend is now on the master branch.

Jef


More information about the devel mailing list