[PATCH] Minor error in serial_configure
Jef Driesen
jef at libdivecomputer.org
Tue May 13 04:37:23 PDT 2014
On 2014-05-13 11:39, Venkatesh Shukla wrote:
> I have attached a patch to a minute mistake that I noticed in the code.
>
> - if (memcmp (&tty, &active, sizeof (struct termios) != 0)) {
> + if (memcmp (&tty, &active, sizeof (struct termios)) !=0) {
Nice catch! I'll apply the patch.
Due to this bug, the memcmp only checked the first byte. I wonder
whether fixing this will have any negative side effect, with this
discussion in mind:
http://libdivecomputer.org/pipermail/devel/2014-March/000268.html
Anyway, we'll find out soon enough.
Jef
More information about the devel
mailing list