Connection with Smart Z hangs
Hi, since my Windows machine stopped working and I cannot read out my Uwatec Smart Z computer anymore on this computer, I tried doing directly with my Ubuntu workstation. Unfortunately subsurface hangs always during import of the dive logs. So I tried the test application from libdivecomputer.
martin@Asterix:~/Downloads$ ./smart /dev/ttyS1 DATETIME 2014-10-22T09:19:17Z (1413969557) VERSION 0.5.0-devel (61e9847196b4e7f4e2c80e47dd6cd7070c9c4418) uwatec_smart_device_open INFO: Discover: address=ebd76f01, name=Aladin Smart Z, charset=00, hints=8000 INFO: Connect: address=ebd76f01, lsap=1
After that the window freezes and the smart application hangs. The system is an Ubuntu 14.10 system. Any help is highly appreciated.
On 22-10-14 12:10, Martin Lang wrote:
since my Windows machine stopped working and I cannot read out my Uwatec Smart Z computer anymore on this computer, I tried doing directly with my Ubuntu workstation. Unfortunately subsurface hangs always during import of the dive logs. So I tried the test application from libdivecomputer.
martin@Asterix:~/Downloads$ ./smart /dev/ttyS1 DATETIME 2014-10-22T09:19:17Z (1413969557) VERSION 0.5.0-devel (61e9847196b4e7f4e2c80e47dd6cd7070c9c4418) uwatec_smart_device_open INFO: Discover: address=ebd76f01, name=Aladin Smart Z, charset=00, hints=8000 INFO: Connect: address=ebd76f01, lsap=1
After that the window freezes and the smart application hangs. The system is an Ubuntu 14.10 system.
Any help is highly appreciated.
I've no idea what's going wrong here. Can you try to run under strace to see whether it's still busy in some syscall? Running under a debugger should work too, if you're familiar doing that. Jef
Ok, I debugged a little bit and got the impression that the problem is with the IRDA driver and not libdivecomputer. strace gave: .... gettimeofday({1414947379, 477685}, NULL) = 0 write(2, "INFO: Connect: address=ebd76f01,"..., 40INFO: Connect: address=ebd76f01, lsap=1 ) = 40 connect(4, {sa_family=AF_IRDA, sa_data="\1\0\1o\327\353\0\0\0\0\0\0\0\0"}, 36 But immediately after the connect I got a Kernel OOPs: [ 348.319858] usbcore: registered new interface driver mcs7780 [ 763.753777] IrLAP, no activity on link! [ 765.354442] IrLAP, no activity on link! [ 766.955107] IrLAP, no activity on link! [ 767.319321] BUG: unable to handle kernel NULL pointer dereference at (null) [ 767.319423] IP: [< (null)>] (null) [ 767.319482] PGD 3bd506067 PUD 3bd55f067 PMD 0 [ 767.319541] Oops: 0010 [#1] SMP [ 767.319584] Modules linked in: mcs7780 irda_usb irda crc_ccitt snd_hda_codec_hdmi snd_hda_codec_realtek bnep rfcomm bluetooth x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm eeepc_wmi asus_wmi sparse_keymap crct10dif_pclmul crc32_pclmul uvcvideo ghash_clmulni_intel snd_hda_intel videobuf2_vmalloc snd_hda_codec snd_usb_audio videobuf2_memops videobuf2_core snd_usbmidi_lib ftdi_sio videodev usbserial snd_hwdep snd_pcm i915 aesni_intel snd_page_alloc aes_x86_64 binfmt_misc lrw gf128mul snd_seq_midi glue_helper snd_seq_midi_event snd_rawmidi ablk_helper snd_seq cryptd drm_kms_helper mei_me drm serio_raw snd_seq_device mei snd_timer lpc_ich i2c_algo_bit snd soundcore wmi video mac_hid parport_pc ppdev lp parport nls_iso8859_1 hid_generic usbhid hid ahci r8169 libahci mii [ 767.320541] CPU: 0 PID: 3093 Comm: smart Not tainted 3.13.0-37-generic #64-Ubuntu [ 767.320621] Hardware name: ASUS All Series/H87M-PRO, BIOS 1101 12/02/2013 [ 767.320694] task: ffff8803bd741800 ti: ffff8803bd696000 task.ti: ffff8803bd696000 [ 767.320787] RIP: 0010:[<0000000000000000>] [< (null)>] (null) [ 767.320870] RSP: 0018:ffff8803bd697e00 EFLAGS: 00010206 [ 767.320928] RAX: ffffffffa02cf2c0 RBX: ffff8803de716d00 RCX: ffff8803bd505f08 [ 767.321002] RDX: ffff8803bd505f08 RSI: 0000000000000002 RDI: ffff880407867000 [ 767.321076] RBP: ffff8803bd697e78 R08: 0000000000000212 R09: 0000000000000003 [ 767.321150] R10: 0000000000000004 R11: 0000000000000005 R12: ffff8803bd697e90 [ 767.321224] R13: ffff880407867000 R14: 0000000000000000 R15: 0000000000000024 [ 767.321300] FS: 0000000000000000(0000) GS:ffff88041fa00000(0063) knlGS:00000000f75f5940 [ 767.321384] CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033 [ 767.321444] CR2: 0000000000000000 CR3: 00000003bd665000 CR4: 00000000001407f0 [ 767.321518] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 767.321592] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 767.321665] Stack: [ 767.321689] ffffffffa02c75c6 0000000000000000 ffffffff810789db 0000000000000000 [ 767.321780] 00000002bd697e58 0000000000000000 ffff8803bd741800 ffffffff810aafd0 [ 767.321870] ffff8803bd697e40 ffff8803bd697e40 ffff8803de716d00 0000000000000024 [ 767.321960] Call Trace: [ 767.322008] [<ffffffffa02c75c6>] ? irda_connect+0x156/0x480 [irda] [ 767.322083] [<ffffffff810789db>] ? ptrace_stop+0x1cb/0x2c0 [ 767.322150] [<ffffffff810aafd0>] ? prepare_to_wait_event+0x100/0x100 [ 767.322223] [<ffffffff8160a6a7>] SYSC_connect+0xe7/0x120 [ 767.322286] [<ffffffff81079f0f>] ? ptrace_notify+0x5f/0xc0 [ 767.322348] [<ffffffff8160b3fe>] SyS_connect+0xe/0x10 [ 767.322408] [<ffffffff81642700>] compat_sys_socketcall+0x1f0/0x260 [ 767.322479] [<ffffffff8173152c>] sysenter_dispatch+0x7/0x21 [ 767.322540] Code: Bad RIP value. [ 767.322585] RIP [< (null)>] (null) [ 767.322643] RSP <ffff8803bd697e00> [ 767.322681] CR2: 0000000000000000 [ 767.348054] ---[ end trace e742aca706087bcd ]--- I will try to debug a little bit more. Thank you On 26.10.2014 20:38, Jef Driesen wrote:
On 22-10-14 12:10, Martin Lang wrote:
since my Windows machine stopped working and I cannot read out my Uwatec Smart Z computer anymore on this computer, I tried doing directly with my Ubuntu workstation. Unfortunately subsurface hangs always during import of the dive logs. So I tried the test application from libdivecomputer.
martin@Asterix:~/Downloads$ ./smart /dev/ttyS1 DATETIME 2014-10-22T09:19:17Z (1413969557) VERSION 0.5.0-devel (61e9847196b4e7f4e2c80e47dd6cd7070c9c4418) uwatec_smart_device_open INFO: Discover: address=ebd76f01, name=Aladin Smart Z, charset=00, hints=8000 INFO: Connect: address=ebd76f01, lsap=1
After that the window freezes and the smart application hangs. The system is an Ubuntu 14.10 system.
Any help is highly appreciated.
I've no idea what's going wrong here. Can you try to run under strace to see whether it's still busy in some syscall? Running under a debugger should work too, if you're familiar doing that.
Jef _______________________________________________ devel mailing list devel@libdivecomputer.org http://libdivecomputer.org/cgi-bin/mailman/listinfo/devel
On Sun, Nov 2, 2014 at 9:26 AM, Martin Lang <mlg.hessigheim@gmail.com> wrote:
I debugged a little bit and got the impression that the problem is with the IRDA driver and not libdivecomputer.
Looks that way.
[ 767.319321] BUG: unable to handle kernel NULL pointer dereference at (null) [ 767.320541] CPU: 0 PID: 3093 Comm: smart Not tainted 3.13.0-37-generic #64-Ubuntu
Ugh. 3.13. I guess you can't get anything newer through Ubuntu without going through some big upgrade of everything. Not that I see any likely fixes since 3.13. Irda is basically dead technology, the only user we ever see any more are a very few dive computers. So nobody maintains it any more. In fact, we had this very bug reported last *year*, and I debugged it, and sent my
[ 767.322008] [<ffffffffa02c75c6>] ? irda_connect+0x156/0x480 [irda] [ 767.322540] Code: Bad RIP value.
Ok, it's a call to a NULL pointer, which is bad. The only such call is the sk->sk_prot->disconnect() call, and the "disconnect" function for irda is NULL, always has been and probably always will be. And nobody has ever fixed this. There was a thread in late december last year (and early January this year about this particular oops and another one) where I reported this, and people agreed that it was all bogus. There was a separate locking issue too, which wasn't as simple. David, I'm just going to remove that whole bogus disconnect call. It won't make things *work* for Martin (because this is all in the "connect failed" path), but that call as-is is just wrong, wrong, wrong. And apparently nobody cares about irda any more. If anybody is at all interested in helping maintain irda code, holler to David and to the netdev mailing list. The position is up for grabs. Linus
From: Linus Torvalds <torvalds@linux-foundation.org> Date: Sun, 2 Nov 2014 10:20:22 -0800
David, I'm just going to remove that whole bogus disconnect call. It won't make things *work* for Martin (because this is all in the "connect failed" path), but that call as-is is just wrong, wrong, wrong. And apparently nobody cares about irda any more.
I totally agree, just kill it. For the record this got added in: commit 5b40964eadea40509d353318d2c82e8b7bf5e8a5 Author: Samuel Ortiz <samuel@sortiz.org> Date: Mon Oct 11 00:46:51 2010 +0200 irda: Remove BKL instances from af_irda.c which claims to be just a locking change, but obviously added this bogus ->disconnect() call as well.
If anybody is at all interested in helping maintain irda code, holler to David and to the netdev mailing list. The position is up for grabs.
Seriously... :-)
participants (5)
-
David Miller -
Jef Driesen -
Linus Torvalds -
Martin Lang -
Martin Lang