On Tue, Oct 28, 2014 at 11:36 AM, Dirk Hohndel dirk@hohndel.org wrote:
I need to understand what you pass to the callback:
if (!callback(dc_buffer_get_data(file), dc_buffer_get_size(file), NULL, 0, userdata))What's in that buffer?
That's just the whole dive file.
You can do this already. You just need to cheat. DC_SAMPLE_VENDOR allows you to pass data of a given length. Simply have two strings in there, both \0 terminated.
Yeah,. and I refuse to use shit like that.
Sorry, Jeff, but if it's a string, it had better be *defined* as a string. Not "random memory data that you aren't guaranteed to be able to show".
The DC_SAMPLE_VENDOR callback could be any garbage, certainly *not* something that subsurface could then show as divecomputer information. There are multuiple DC backends that use it, and they all just use it for random binary data. And that's just useless shit, pardon my French.
Linus