On Thu, Jul 20, 2017 at 6:52 AM, Dirk Hohndel dirk@hohndel.org wrote:
Sorry for top post.
How about when you tap the button / check the box that enables time since, we open a pop-up with the current time and ask the user to confirm? Yeah, I know. Pop-ups are evil. But this does seem like one of those cases where maybe it's worth it? Because I like the time sync idea.
I could live with the popup but it might get annoying if this pops up every time I do the sync during a dive trip.
Linus, this popup would be while selecting the timesync on Subsurface UI, or clicking the download button, depending on how it would be implemented. So not yet in libdc.
There is one flaw, though, now that I think about it. Usually you download your dives after a day of diving. They may not be the best time to adjust the time zone...
Do we get the current time from the DC. If so, we could automatically adjusting the time of the downloaded dives. Or something else cleverness. I have had one DC on incorrect time more than once at the start of dive trip. Wristwatch type DC is always set to local time but the bulky ones that are in hand luggage might get forgotten :(
miika
-- From my phone ________________________________ From: Miika Turkia Sent: Wed Jul 19 20:45:03 PDT 2017 To: Linus Torvalds Cc: Subsurface Mailing List , Dirk Hohndel , Jef Driesen , devel Subject: Re: [RFD] divecomputer time/date synchronization while downloading dives
On Wed, Jul 19, 2017 at 11:08 PM, Linus Torvalds torvalds@linux-foundation.org wrote:
Anyway, what this all builds up to is that I'd actually like to just set the time automatically when I connect the dive computer to my laptop (or my cellphone, for that matter - usually those end up being synchronized to the local time quite nicely).
I do like the idea, but I am hesitant about syncing the time with laptop automatically. That is because it usually takes a few days for me to update my timezone. Even with the manual time sync, it has happened to me once that I synced wrong time to my DC. Also with my tablet, there is no automatic timezone changes so the mobile version might also be missing the correct time.
But I suspect people will hate that patch because it does that time sync thing *unconditionally*. It would be good to have a check-box and some way to actually set the "sync time" flag. But for that to happen, we'd need not just the UI side, we'd need to have the libdivecomputer interface too.
I am thinking about a nagging popup in case we have not been diving in more than a day to remind to set the timezone correctly on computer before syncing the time (if enabled). Or something less annoying for the incompetent people who cannot keep their timezones :D Maybe just a checkbox on the download dialog to enable this feature per DC connection - maybe even remember the setting until no-fly clears.
miika