On Jan 6, 2015 11:47 AM, "Jef Driesen" <jef@libdivecomputer.org> wrote:
>
> These functions aren't used anywhere. Is that on purpose, or is there something missing in the patch?
Not missing, no. Just too much cut-and-paste. The case statement with the actual callbacks does the "warning" callbacks twice. The second set should be "alarm" (ie cases 0x0019 and 0x001a).
Why didn't I notice the compiler warning? Hmm. Probably because the build system is so verbose. There is a reason why the kernel (and subsurface) builds try to be quiet. Or maybe the warning flags aren't complete enough. I'm mobile, so can't test.
Linus