From: Linus Torvalds torvalds@linux-foundation.org Date: Mon, 29 Aug 2016 15:03:02 -0700 Subject: [PATCH 3/3] Suunto EON Steel: extend our string space
We only used to save 16 extended strings per dive from the EON Steel download, which is _plenty_: it's not like we actually generate that many strings. Firmware version, battery status, transmitter info - there's just not that many strings.
Oops.
Except if you have lots of transmitters. Then each wireless transmitter will have three strings each, for transmitter ID and beginning/ending battery status.
I only have one, but Andreas Klein has four. And it took me embarrassingly long to realize that he really did have them on the dives, because after the first two transmitter IDs got recorded, the string space filled up and we silently dropped the rest.
But I have learnt my lesson. Future generations will talk about how I said "32 strings will be enough for anybody".
But at least it should be enough for a few more transmitters. Somebody should extend this some better way, but I'm still chasing other issues.
Signed-off-by: Linus Torvalds torvalds@linux-foundation.org --- src/suunto_eonsteel_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/suunto_eonsteel_parser.c b/src/suunto_eonsteel_parser.c index 8a7d3d15cbc8..fc1301d94139 100644 --- a/src/suunto_eonsteel_parser.c +++ b/src/suunto_eonsteel_parser.c @@ -80,7 +80,7 @@ struct type_desc {
#define MAXTYPE 512 #define MAXGASES 16 -#define MAXSTRINGS 16 +#define MAXSTRINGS 32
typedef struct suunto_eonsteel_parser_t { dc_parser_t base;