On 2015-09-03 20:01, Anton Lundin wrote:
On 03 September, 2015 - Jef Driesen wrote:
On 2015-08-31 23:06, Anton Lundin wrote:
The HwOS devices logs ppo2 sensor values even in Auto / Fixed SP mode, but they log them as reading zero, if there are no sensors there.
Am I right that in this particular case all three ppo2 values are zero (e.g. no sensors at all)? I remember seeing that in some of the original OSTC memory dumps. Then it makes indeed sense to omit the ppo2 values. But if there is one or more non-zero values, I don't think we should omit just the zero ones.
In the Auto / Fixed SP mode all three values are zero, and stays zero during the hole dive.
This fix isn't bug-free, eg if a sensor gets disconnected during a dive, we should report zero for that, but it feels like the lesser evil than the current code.
What I meant was something like the attached patch: If all three values are zero, there are probably no sensors, and we ignore all three ppo2 samples. But if there is at least one non-zero value, we report all three values.
I dropped a mail to HW suggesting to just not log any sensors in Auto / Fixed SP mode which would kinda make sense. Right now the HwOS based devices logs ppo2 in all CCR modes.
That's sounds like the right solution to me. But even if this gets fixed in a future firmware, we'll still need a fix on our side for all past dives.
Jef