On 12-01-17 18:17, Kristaps Dzonsons wrote:
Yes, I think that's better. With the caveats section and the current description ("might interact with the file-system in unexpected ways"), it sounds as if there is a problem. And that's not really true.
I agree: enter version 3! (Minus the Makefile.am bits.) This just has the notice as a separate paragraph.
I've applied your patches.
An unrelated note: I found that sometimes you use dc_datetime_gmtime and sometimes dc_datetime_localtime for the dc_parser_get_datetime value. So is it correct to say that the value always returns the broken-down localtime? (Specifically: the shearwater predator, suunto eon steel, and uwatec smart computers invoke gmtime. The uwatec specifically notes the rationale behind this, however.)
Yes, it's always local time. That's what users expect to get (and what most dive computers record). Whether we need to use localtime or gmtime depends on how the dive computer records its timestamp.
Jef