[PATCH] Cochran: Changed communication parameter to work better with FTDI.

Jef Driesen jef at libdivecomputer.org
Mon Sep 11 02:22:27 PDT 2017


On 2017-09-06 22:02, John Van Ostrand wrote:
> The parameters used with the FTDI USB serial port drivers didn't
> work well with directly with libftdi1. The new baud rate results
> in the same effective baud rates for both.

What's the effective baudrate? Why don't you just use that effective 
baudrate, instead of 850000? Now the baudrate change looks rather 
arbitrary to me.

Other than that, the changes look good to me. For the retrying, I'll 
restore the old retry function (see commit 
b3d2c603ddec9758fb36706bbde46ce23ca9f0ed) because it handles fatal 
errors better.

Jef


More information about the devel mailing list