[PATCH 4/4] Add EON Steel bookmarks, warnings and alarm events

Linus Torvalds torvalds at linux-foundation.org
Tue Jan 6 12:00:32 PST 2015


On Jan 6, 2015 11:47 AM, "Jef Driesen" <jef at libdivecomputer.org> wrote:
>
> These functions aren't used anywhere. Is that on purpose, or is there
something missing in the patch?

Not missing, no. Just too much cut-and-paste. The case statement with the
actual callbacks does the "warning" callbacks twice. The second set should
be "alarm" (ie cases 0x0019 and 0x001a).

Why didn't I notice the compiler warning? Hmm. Probably because the build
system is so verbose. There is a reason why the kernel (and subsurface)
builds try to be quiet. Or maybe the warning flags aren't complete enough.
I'm mobile, so can't test.

   Linus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://libdivecomputer.org/pipermail/devel/attachments/20150106/0008bf45/attachment.html>


More information about the devel mailing list