[PATCH] Minor error in serial_configure

Linus Torvalds torvalds at linux-foundation.org
Tue May 27 16:05:32 PDT 2014


On Tue, May 27, 2014 at 6:16 AM, Jef Driesen <jef at libdivecomputer.org> wrote:
>
> So most likely, either this memcmp will have to be removed completely, or at
> least conditionally compiled on the ENABLE_PTY macro.

I'd suggest just removing it entirely. The check just doesn't make
sense, even ignoring the whole padding issue (and no, initializing it
to zero doesn't fix it, since there might be random private members
outside the spec) that might get initialized.

         Linus


More information about the devel mailing list